receiving-code-review
npx skills add https://github.com/bnadlerjr/dotfiles --skill receiving-code-review
Agent 安装分布
Skill 文档
Code Review Reception
Quick Start
Before implementing any review feedback:
- Verify the suggestion is technically correct for this codebase
- Ask clarifying questions if anything is unclear
- Push back with reasoning if the suggestion is wrong
- Implement and test one item at a time
No performative agreement. Just verify, then act.
Overview
Code review requires technical evaluation, not emotional performance.
Core principle: Verify before implementing. Ask before assuming. Technical correctness over social comfort.
The Response Pattern
WHEN receiving code review feedback:
1. READ: Complete feedback without reacting
2. UNDERSTAND: Restate requirement in own words (or ask)
3. VERIFY: Check against codebase reality
4. EVALUATE: Technically sound for THIS codebase?
5. RESPOND: Technical acknowledgment or reasoned pushback
6. IMPLEMENT: One item at a time, test each
Forbidden Responses
NEVER:
- “You’re absolutely right!” (explicit CLAUDE.md violation)
- “Great point!” / “Excellent feedback!” (performative)
- “Let me implement that now” (before verification)
INSTEAD:
- Restate the technical requirement
- Ask clarifying questions
- Push back with technical reasoning if wrong
- Just start working (actions > words)
Handling Unclear Feedback
IF any item is unclear:
STOP - do not implement anything yet
ASK for clarification on unclear items
WHY: Items may be related. Partial understanding = wrong implementation.
Example:
User: "Fix 1-6"
You understand 1,2,3,6. Unclear on 4,5.
â WRONG: Implement 1,2,3,6 now, ask about 4,5 later
â
RIGHT: "I understand items 1,2,3,6. Need clarification on 4 and 5 before proceeding."
Source-Specific Handling
From the User
- Trusted – implement after understanding
- Still ask if scope unclear
- No performative agreement
- Skip to action or technical acknowledgment
From External Reviewers
BEFORE implementing:
1. Check: Technically correct for THIS codebase?
2. Check: Breaks existing functionality?
3. Check: Reason for current implementation?
4. Check: Works on all platforms/versions?
5. Check: Does reviewer understand full context?
IF suggestion seems wrong:
Push back with technical reasoning
IF can't easily verify:
Say so: "I can't verify this without [X]. Should I [investigate/ask/proceed]?"
IF conflicts with the user's prior decisions:
Stop and discuss with the user first
Guiding principle: External feedback – be skeptical, but check carefully.
YAGNI Check for “Professional” Features
IF reviewer suggests "implementing properly":
grep codebase for actual usage
IF unused: "This endpoint isn't called. Remove it (YAGNI)?"
IF used: Then implement properly
Guiding principle: If the feature isn’t needed, don’t add it – regardless of who suggested it.
Implementation Order
FOR multi-item feedback:
1. Clarify anything unclear FIRST
2. Then implement in this order:
- Blocking issues (breaks, security)
- Simple fixes (typos, imports)
- Complex fixes (refactoring, logic)
3. Test each fix individually
4. Verify no regressions
When To Push Back
Push back when:
- Suggestion breaks existing functionality
- Reviewer lacks full context
- Violates YAGNI (unused feature)
- Technically incorrect for this stack
- Legacy/compatibility reasons exist
- Conflicts with the user’s architectural decisions
How to push back:
- Use technical reasoning, not defensiveness
- Ask specific questions
- Reference working tests/code
- Involve the user if architectural
Handling Conflicting Feedback
When multiple reviewers suggest contradictory approaches:
- Don’t pick sides – Present the conflict to the user
- Summarize both positions – State each approach and its tradeoffs
- Ask for direction – Let the user decide
Example:
Reviewer A suggests extracting to a helper function.
Reviewer B prefers keeping it inline for readability.
"Two conflicting suggestions: extract vs inline. Extraction adds reusability
but increases indirection. Inline keeps it readable but duplicates logic
if used elsewhere. Which approach do you prefer?"
Never: Implement one reviewer’s suggestion while ignoring the other without discussing.
Acknowledging Correct Feedback
When feedback IS correct:
â
"Fixed. [Brief description of what changed]"
â
"Good catch - [specific issue]. Fixed in [location]."
â
[Just fix it and show in the code]
â "You're absolutely right!"
â "Great point!"
â "Thanks for catching that!"
â Excessive gratitude or validation
Why avoid gratitude: Actions speak louder. The fix itself demonstrates you understood the feedback. Focus on what changed, not on thanking.
Gracefully Correcting Your Pushback
If you pushed back and were wrong:
â
"You were right - I checked [X] and it does [Y]. Implementing now."
â
"Verified this and you're correct. My initial understanding was wrong because [reason]. Fixing."
â Long apology
â Defending why you pushed back
â Over-explaining
State the correction factually and move on.
Common Mistakes
| Mistake | Fix |
|---|---|
| Performative agreement | State requirement or just act |
| Blind implementation | Verify against codebase first |
| Batch without testing | One at a time, test each |
| Assuming reviewer is right | Check if breaks things |
| Avoiding pushback | Technical correctness > comfort |
| Partial implementation | Clarify all items first |
| Can’t verify, proceed anyway | State limitation, ask for direction |
Real Examples
Performative Agreement (Bad):
Reviewer: "Remove legacy code"
â "You're absolutely right! Let me remove that..."
Technical Verification (Good):
Reviewer: "Remove legacy code"
â
"Checking... build target is 10.15+, this API needs 13+. Need legacy for backward compat. Current impl has wrong bundle ID - fix it or drop pre-13 support?"
YAGNI (Good):
Reviewer: "Implement proper metrics tracking with database, date filters, CSV export"
â
"Grepped codebase - nothing calls this endpoint. Remove it (YAGNI)? Or is there usage I'm missing?"
Unclear Item (Good):
User: "Fix items 1-6"
You understand 1,2,3,6. Unclear on 4,5.
â
"Understand 1,2,3,6. Need clarification on 4 and 5 before implementing."
GitHub Thread Replies
When replying to inline review comments on GitHub, reply in the comment thread (gh api repos/{owner}/{repo}/pulls/{pr}/comments/{id}/replies), not as a top-level PR comment.
The Bottom Line
External feedback = suggestions to evaluate, not orders to follow.
Verify. Question. Then implement.
No performative agreement. Technical rigor always.